netdev - Re: [PATCH 1/2] sky2: EEPROM read/write bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080828083035.7c6f8f42@extreme>
Date:	Thu, 28 Aug 2008 08:30:35 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] sky2: EEPROM read/write bug fixes

On Thu, 28 Aug 2008 12:13:25 +0100
Ben Hutchings <bhutchings@...arflare.com> wrote:

> Stephen Hemminger wrote:
> > Cleanup and harden the routines accessing the EEPROM.
> >   1. Prevent spin forever waiting for the TWSI bus
> >   2. Fix write eeprom to write full words rather than only 16 bits 
> >     Luckly the vendor doesn't provide EEPROM in Linux format so it must never
> >     have been used.
> >   3. Don't allow partial eeprom writes, not needed, not safe.
> [...]
> 
> You should be able to replace the VPD access code with calls through
> pci_dev->vpd->ops - though you'd need to remove some declarations from
> drivers/pci/pci.h to include/linux/pci.h.
> 
> Ben.
> 

Generically a good idea, but it won't work for this device.
It turns out that the read/write timeouts in pci/access.c are too
short. Since the pci vpd code spins under spin lock with irq's disabled,
it really can't wait for up to 10ms!

Minor note: the pci code seems to be much more verbose with little
gain in real functionality.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html