netdev - Re: [NET_NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f2db9d90808280907i747f4343j58c30e3020a1940d@mail.gmail.com>
Date:	Thu, 28 Aug 2008 09:07:20 -0700
From:	"Alexander Duyck" <alexander.duyck@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	jeffrey.t.kirsher@...el.com, jeff@...zik.org,
	netdev@...r.kernel.org, alexander.h.duyck@...el.com
Subject: Re: [NET_NEXT PATCH 1/2] pkt_sched: Add multiqueue scheduler support

> It looks mostly fine.
>
> But I wonder how useful this "bands" parameter is.
> It behaves as follows:
>
> 1) "1" is always allowed, essentially non-multiqueue
> 2) ->real_num_tx_queues is always allowed
> 3) 0 means auto detect, which is also ->real_num_tx_queues
>
> Everything else is rejected.
>

Actually you give me too much credit.  I don't think bands even works
as a boolean, or at least it wasn't meant to.  It was supposed to be 0
or the number of queues which either way ends up the number of queues.
 It was a bit of leftover interface from the rr/prio configuration.  I
realized I left that in there when I was driving home last night but
by then it was too late.

I will probably just have it always default the number of bands to
always be real_num_tx_queues and save the user from having to enter
bands in the tc command line.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html