netdev - Re: [RESEND 2.6.27] netlink: Remove compat API for nested attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080902232008.GD20815@postel.suug.ch>
Date:	Wed, 3 Sep 2008 01:20:09 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RESEND 2.6.27] netlink: Remove compat API for nested attributes

* Alexander Duyck <alexander.h.duyck@...el.com> 2008-09-02 14:46
> Thomas Graf wrote:
> >Removes all _nested_compat() functions from the API. The prio qdisc
> >no longer requires them and netem has its own format anyway. Their
> >existance is only confusing.
> >
> >Resend: Also remove the wrapper macro.
> >
> >Signed-off-by: Thomas Graf <tgraf@...g.ch>
> >
> I don't think we need to do anything as drastic as completely throwing 
> out this part of the Kernel ABI.  This is what I have been trying to get 
> at all along.  All we need to do is revert the two patches that we 
> talked about earlier and everything goes back to working.

Ever since the multiqueue bits have been removed from prio in net-next,
prio no longer requires the compat functions which leaves netem as the 
sole user. As you know, netem isn't really using the "compat" format but
instead uses its own format which was the origin of all this trouble.
Therefore I propose to move the current nla_parse_nested_compat() code
to netem and remove the API alltogether since there is no real user of
the original compat interface anymore. Leaving them around would only
encourage new code to use it.

Note that this patch is against the net-next tree which is not affected
by the prio regression (as the multiqueue bits have been removed) and
does not aim at resolving the regression. See my separate patch against
the stable tree which aims at resovling the prio regression.
Alternatively, reverting Patrick's and my patch in the stable tree is
perfectly fine with me as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html