netdev - Re: [RESEND 2.6.27] netlink: Remove compat API for nested attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Sep 2008 17:27:28 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	Thomas Graf <tgraf@...g.ch>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RESEND 2.6.27] netlink: Remove compat API for nested attributes

Thomas Graf wrote:
> Ever since the multiqueue bits have been removed from prio in net-next,
> prio no longer requires the compat functions which leaves netem as the
> sole user. As you know, netem isn't really using the "compat" format but
> instead uses its own format which was the origin of all this trouble.
> Therefore I propose to move the current nla_parse_nested_compat() code
> to netem and remove the API alltogether since there is no real user of
> the original compat interface anymore. Leaving them around would only
> encourage new code to use it.

That is the point of code like this.  It defines a standard set of tools 
for extending an existing netlink interface.  If nothing else we should 
standardize on the netem approach for both parsing and creation since 
prio no longer ueses the compat attributes.

> Note that this patch is against the net-next tree which is not affected
> by the prio regression (as the multiqueue bits have been removed) and
> does not aim at resolving the regression. See my separate patch against
> the stable tree which aims at resovling the prio regression.
> Alternatively, reverting Patrick's and my patch in the stable tree is
> perfectly fine with me as well.

I saw your patches against the stable trees, and I would be happy with 
your solution or the reverting of the patches as long as one of them is 
implemented.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html