netdev - Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48BE9B52.8050003@garzik.org>
Date:	Wed, 03 Sep 2008 10:12:34 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Krzysztof Halasa <khc@...waw.pl>
CC:	Adrian Bunk <bunk@...nel.org>, Jeff Garzik <jgarzik@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

Krzysztof Halasa wrote:
> Adrian Bunk <bunk@...nel.org> writes:
> 
>> --- a/drivers/net/wan/hdlc_x25.c
>> +++ b/drivers/net/wan/hdlc_x25.c
>> @@ -163,10 +163,8 @@ static void x25_close(struct net_device *dev)
>>  
>>  static int x25_rx(struct sk_buff *skb)
>>  {
>> -	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
>> -		skb->dev->stats.rx_dropped++;
>> +	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
>>  		return NET_RX_DROP;
>> -	}
>>  
> 
> Right, thanks... though I will update the stats anyway.

In terms of patches... what does this mean?  Does this mean you are 
taking Adrian's patch, and updating it?  Sending a follow-up patch? 
Ack'ing Adrian's patch?

I don't want to hold this back due to lack of stat update...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html