netdev - Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3bpz9glik.fsf@maximus.localdomain>
Date:	Sun, 31 Aug 2008 19:08:35 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Jeff Garzik <jgarzik@...hat.com>, netdev@...r.kernel.org
Subject: Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

Adrian Bunk <bunk@...nel.org> writes:

> --- a/drivers/net/wan/hdlc_x25.c
> +++ b/drivers/net/wan/hdlc_x25.c
> @@ -163,10 +163,8 @@ static void x25_close(struct net_device *dev)
>  
>  static int x25_rx(struct sk_buff *skb)
>  {
> -	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
> -		skb->dev->stats.rx_dropped++;
> +	if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
>  		return NET_RX_DROP;
> -	}
>  

Right, thanks... though I will update the stats anyway.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html