netdev - Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1KYy5u-000243-00@gondolin.me.apana.org.au>
Date:	Fri, 29 Aug 2008 17:08:30 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	bunk@...nel.org (Adrian Bunk)
Cc:	khc@...waw.pl, jgarzik@...hat.com, netdev@...r.kernel.org
Subject: Re: [2.6 patch] wan/hdlc_x25.c: fix a NULL dereference

Adrian Bunk <bunk@...nel.org> wrote:
>
> static int x25_rx(struct sk_buff *skb)
> {
> -       if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
> -               skb->dev->stats.rx_dropped++;
> +       if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL)
>                return NET_RX_DROP;
> -       }

Why not keep the stat collection? It's not like saving skb->dev
on the stack is hard or anything...

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html