netdev - Re: [PATCH 3/3] ibm_newemac: MAL support for PowerPC 405EZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1220607278.4879.165.camel@pasglop>
Date:	Fri, 05 Sep 2008 19:34:38 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>
Cc:	Simon Horman <horms@...ge.net.au>, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH 3/3] ibm_newemac: MAL support for PowerPC 405EZ


> > > +	if (of_device_is_compatible(ofdev->node, "ibm,mcmal-405ez"))
> > > +		mal->features |= (MAL_FTR_CLEAR_ICINTSTAT | MAL_FTR_COMMON_ERR_INT);
> > 
> > The above like is >80 characters wide.
> > But I'm not sure that anyone cares.
> 
> I don't.  If Ben complains I'll change it.

I wouldn't do a tatrum over it but if you're going to respin the
patch you may as well put the second constant on the next line.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html