netdev - Re: [PATCH] pkt_sched: Fix qdisc state in net_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080905102600.GA30417@gondor.apana.org.au>
Date:	Fri, 5 Sep 2008 20:26:00 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Denys Fedoryshchenko <denys@...p.net.lb>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: Fix qdisc state in net_tx_action()

On Fri, Sep 05, 2008 at 08:29:15AM +0000, Jarek Poplawski wrote:
> 
> pkt_sched: Fix qdisc state in net_tx_action()
> 
> net_tx_action() can skip __QDISC_STATE_SCHED bit clearing while qdisc
> is neither ran nor rescheduled, which may cause endless loop in
> dev_deactivate().
> 
> Reported-by: Denys Fedoryshchenko <denys@...p.net.lb>
> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>

Good catch!

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html