netdev - Re: [RFC PATCH v5 05/14] smack: Fix missing calls to netlbl_skbuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48C1E69A.2050002@schaufler-ca.com>
Date:	Fri, 05 Sep 2008 19:10:34 -0700
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Paul Moore <paul.moore@...com>
CC:	selinux@...ho.nsa.gov, netdev@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [RFC PATCH v5 05/14] smack: Fix missing calls to netlbl_skbuff_err()

Paul Moore wrote:
> Smack needs to call netlbl_skbuff_err() to let NetLabel do the necessary
> protocol specific error handling.
>
> Signed-off-by: Paul Moore <paul.moore@...com>
>   
Acked-by: Casey Schaufler <casey@...aufler-ca.com>

> ---
>
>  security/smack/smack_lsm.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 87d7541..6e2dc0b 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -2179,7 +2179,10 @@ static int smack_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
>  	 * This is the simplist possible security model
>  	 * for networking.
>  	 */
> -	return smk_access(smack, ssp->smk_in, MAY_WRITE);
> +	rc = smk_access(smack, ssp->smk_in, MAY_WRITE);
> +	if (rc != 0)
> +		netlbl_skbuff_err(skb, rc, 0);
> +	return rc;
>  }
>  
>  /**
>
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@...ho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
>
>
>   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html