netdev - Re: [rfc 0/3] IPVS: checksum updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2008 21:31:33 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Julius Volz <juliusv@...gle.com>
Cc:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	Siim Põder <siim@...rad-teel.net>,
	Julian Anastasov <ja@....bg>,
	Malcolm Turnbull <malcolm@...dbalancer.org>,
	Vince Busam <vbusam@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [rfc 0/3] IPVS: checksum updates

On Tue, Sep 09, 2008 at 11:30:29AM +0200, Julius Volz wrote:
> On Tue, Sep 9, 2008 at 1:40 AM, Simon Horman <horms@...ge.net.au> wrote:
> > On Mon, Sep 08, 2008 at 12:04:20PM +1000, Simon Horman wrote:
> >> Hi,
> >>
> >> The impetus for this series of patches is Julian Anastasov noting
> >> that "load balance IPv4 connections from a local process" checks
> >> for 0 TCP checksums. Herbert Xu confirmed that this is not legal,
> >> even on loopback traffic, but that rather partial checksums are
> >> possible.
> >>
> >> The first patch in this series is a proposed solution to handle
> >> partial checksums for both TCP and UDP.
> >>
> >> The other two patches clean things up a bit.
> >>
> >> I have not tested this code beyond compilation yet.
> >
> > After extensive testing by Julius Volz and limited testing by myself, I
> > have applied the first patch, which does indeed allow packets with
> > PARTIAL_CHECKSUM to work, to lvs-next-2.6. I have dropped the second two
> > patches which produce bogus checksums.
> 
> Great, thanks! I have tested TCP+UDP, local+remote clients, v4+v6,
> NAT+DSR+TUN in all combinations that are expected to be working and
> found no problems.

Thanks once again for your testing. I'll send a pull request to Dave in
the morning.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html