netdev - Re: [PATCH] Fix dead 21041 ethernet after ifconfig down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080913180509.GA8392@colo.lackof.org>
Date:	Sat, 13 Sep 2008 12:05:09 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:	netdev@...r.kernel.org, grundler@...isc-linux.org,
	kyle@...isc-linux.org, tbm@...ius.com
Subject: Re: [PATCH] Fix dead 21041 ethernet after ifconfig down

On Fri, Sep 12, 2008 at 11:19:19PM +0200, Thomas Bogendoerfer wrote:
> The de2104x did a pci_disable_device() in it's close function, but
> the open function never does a pci_enable_device() and assumes that
> the device is already enabled. Considering that downing the interface
> is just a temporary thing the pci_disable_device() isn't a pretty good
> idea and removing it from the close function just fixes the bug.

Thomas,
Thanks for the patch!

The de2104 driver is calling pci_enable_device() in it's .probe routine
and calls pci_disable_device in it's .remove function.
It never occurred to me a NIC driver would call either pci function
from someplace else as well.

> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

Acked-by: Grant Grundler <grundler@...isc-linux.org>

> ---
> 
>  drivers/net/tulip/de2104x.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
> index 9281d06..f54c450 100644
> --- a/drivers/net/tulip/de2104x.c
> +++ b/drivers/net/tulip/de2104x.c
> @@ -1418,7 +1418,6 @@ static int de_close (struct net_device *dev)
>  
>  	de_free_rings(de);
>  	de_adapter_sleep(de);
> -	pci_disable_device(de->pdev);
>  	return 0;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html