netdev - dead code in tc/m

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080913175812.GA7365@seehuhn.de>
Date:	Sat, 13 Sep 2008 18:58:12 +0100
From:	Jochen Voss <voss@...huhn.de>
To:	netdev@...r.kernel.org
Subject: dead code in tc/m_ematch.c

Hi,

while looking through the source for the Debian package
iproute-20080725, I found the following bit of code (file
tc/m_ematch.c, lines 163-173):

    static struct ematch_util *get_ematch_kind_num(__u16 kind)
    {
	    char name[32];

	    if (lookup_map(kind, name, sizeof(name), EMATCH_MAP) < 0)
		    return NULL;

	    return get_ematch_kind(name);

	    return NULL;
    }

Obviously the second return statement has no effect.  Probably it
should be removed.

I hope this helps,
Jochen
-- 
http://seehuhn.de/

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)