netdev - Re: [PATCH 2.6.28] tcp_ipv6: fix use of uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080914144849.GI12522@elte.hu>
Date:	Sun, 14 Sep 2008 16:48:49 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	acme@...hat.com, vegard.nossum@...il.com, netdev@...r.kernel.org,
	penberg@...helsinki.fi, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.28] tcp_ipv6: fix use of uninitialized memory


* David Miller <davem@...emloft.net> wrote:

> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> Date: Fri, 12 Sep 2008 09:44:05 -0300
> 
> > Em Fri, Sep 12, 2008 at 09:05:25AM +0200, Vegard Nossum escreveu:
> > > >From 6544c4074aa5dde2e3f4d3e02f5601c1c33b770e Mon Sep 17 00:00:00 2001
> > > From: Vegard Nossum <vegard.nossum@...il.com>
> > > Date: Tue, 9 Sep 2008 07:17:32 +0200
> > > Subject: [PATCH] tcp_ipv6: fix use of uninitialized memory
> > > 
> > > inet6_rsk() is called on a struct request_sock * before we
> > > have checked whether the socket is an ipv6 socket or a ipv6-
> > > mapped ipv4 socket. The access that triggers this is the
> > > inet_rsk(rsk)->inet6_rsk_offset dereference in inet6_rsk().
> > > 
> > > This is arguably not a critical error as the inet6_rsk_offset
> > > is only used to compute a pointer which is never really used
> > > (in the code path in question) anyway. But it might be a
> > > latent error, so let's fix it.
> > > 
> > > Spotted by kmemcheck.
> > 
> > Humm, so this was poisoned at allocation and then when inet6_rsk_offset
> > was accessed it noticed, interesting, thanks!
> > 
> > Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Good find :)  I'll add this to net-next-2.6, thanks!

nice - i think kmemcheck is starting to build up a healthy list of 
references :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html