netdev - Re: [PATCH 04/14] Phonet: PF_PHONET protocol family support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809171348.56427.remi.denis-courmont@nokia.com>
Date:	Wed, 17 Sep 2008 13:48:56 +0300
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext Arnaldo Carvalho de Melo" <acme@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 04/14] Phonet: PF_PHONET protocol family support


	Hello,

On Tuesday 16 September 2008 19:17:47 ext Arnaldo Carvalho de Melo, you wrote:
> > +/* Protocols in Phonet protocol family. */
> > +struct phonet_protocol {
> > +	struct proto		*prot;
> > +	int			sock_type;
> > +};
>
> Without looking in detail, first reaction is: don't we have sk_type in
> struct sock? Can't it be used or what you would have in
> ponet_protocol->sock_type be mapped to it?

I would need to have the socket type into struct proto, not in struct sock.
Other families have this "problem" as well (at least inet...).

However, I assume some transport protocols support more than one socket types, 
such that it is not possible to add a socket type to struct proto, right?

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html