netdev - Re: [PATCH 01/14] Phonet global definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200809171405.27954.remi.denis-courmont@nokia.com>
Date:	Wed, 17 Sep 2008 14:05:27 +0300
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext Simon Horman" <horms@...ge.net.au>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 01/14] Phonet global definitions

On Wednesday 17 September 2008 07:31:42 ext Simon Horman, you wrote:
> > +/* Phonet protocol header */
> > +struct phonethdr {
> > +	uint8_t rdev;
> > +	uint8_t sdev;
> > +	uint8_t function;
> > +	uint16_t length;
> > +	uint8_t robj;
> > +	uint8_t sobj;
> > +} __attribute__((packed));
>
> I beleive that the prefered style is to use u8 and friends for internal
> kernel structures and __u8 and friends for ones that are exported to
> userspace. Ditto below.

Now, that explains things. I'll fix all of these, thanks.

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html