[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080918.162948.150019388.davem@davemloft.net>
Date: Thu, 18 Sep 2008 16:29:48 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: vladislav.yasevich@...com
Cc: linux-sctp@...r.kernel.org,
lksctp-developers@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] sctp: Fix oops when INIT-ACK indicates that peer
doesn't support AUTH
From: Vlad Yasevich <vladislav.yasevich@...com>
Date: Thu, 18 Sep 2008 17:31:04 -0400
> If INIT-ACK is received with SupportedExtensions parameter which
> indicates that the peer does not support AUTH, the packet will be
> silently ignore, and sctp_process_init() do cleanup all of the
> transports in the association.
> When T1-Init timer is expires, OOPS happen while we try to choose
> a different init transport.
>
> The solution is to only clean up the non-active transports, i.e
> the ones that the peer added. However, that introduces a problem
> with sctp_connectx(), because we don't mark the proper state for
> the transports provided by the user. So, we'll simply mark
> user-provided transports as ACTIVE. That will allow INIT
> retransmissions to work properly in the sctp_connectx() context
> and prevent the crash.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@...com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists