netdev - Re: clarify code intent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080918.163633.223533656.davem@davemloft.net>
Date:	Thu, 18 Sep 2008 16:36:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mathieu.lacage@...hia.inria.fr
Cc:	netdev@...r.kernel.org
Subject: Re: clarify code intent

From: Mathieu Lacage <mathieu.lacage@...hia.inria.fr>
Date: Thu, 18 Sep 2008 10:07:48 -0700

> The attached patch hopefully clarifies the intent of the unix_bind
> function in net/unix/af_unix.c.

I've rejected this patch over and over in the past, and nothing
has happened to change my mind since then.

----------------------------------------
Subject: Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen
From: David Miller <davem@...emloft.net>
To: samuel.thibault@...-lyon.org
Cc: mtk.manpages@...il.com, mtk.manpages@...glemail.com,
 andi@...stfloor.org, linux-kernel@...r.kernel.org
Date: Sat, 26 Apr 2008 22:54:32 -0700 (PDT)
X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI)

From: Samuel Thibault <samuel.thibault@...-lyon.org>
Date: Sat, 26 Apr 2008 02:44:45 +0100

> AF_UNIX: make unix_getname use sizeof(sunaddr->sun_family) instead of
> sizeof(short).
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

This is just syntactic masterbation, sa_family_t is typedef'd
"unsigned short".

No system on planet earth providing the BSD sockets API uses
anything other than uint16_t or unsigned short for this.

Sorry, I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html