netdev - Re: [patch 4/4] mISDN: misc timerdev fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080923022731.GE25711@one.firstfloor.org>
Date:	Tue, 23 Sep 2008 04:27:32 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, kkeil@...e.de, netdev@...r.kernel.org,
	andi@...stfloor.org, ak@...ux.intel.com
Subject: Re: [patch 4/4] mISDN: misc timerdev fixes

On Mon, Sep 22, 2008 at 07:18:26PM -0700, David Miller wrote:
> From: akpm@...ux-foundation.org
> Date: Mon, 22 Sep 2008 14:51:03 -0700
> 
> > - Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.
> > - Fix timer handler prototype to be correct
> > - Comment ugly SMP race I didn't fix.
> > 
> > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> 
> Applied to net-next-2.6

I'm hoping someone takes care of the SMP race. I think the timers
need all reference counting similar to other network objects to
handle this cleanly.

It might be a good idea to mark it BROKEN_ON_SMP in the meantime.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html