netdev - Re: [patch 4/8] drivers/atm: Use DIV_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080922.192324.149110500.davem@davemloft.net>
Date:	Mon, 22 Sep 2008 19:23:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, julia@...u.dk, chas@....nrl.navy.mil
Subject: Re: [patch 4/8] drivers/atm: Use DIV_ROUND_UP

From: akpm@...ux-foundation.org
Date: Mon, 22 Sep 2008 14:50:39 -0700

> The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
> (d)) but is perhaps more readable.
> 
> In the case of the file drivers/atm/eni.c, I am a little bit suspicious of
> the -1 at the end of the affected expression.  Please check that that is
> what is wanted.
> 
> An extract of the semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@...u.dk>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Looks fine to me, applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html