netdev - Re: [PATCH 0/2] Multicast: add mc_count to in_device and to inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081001.020854.146740849.davem@davemloft.net>
Date:	Wed, 01 Oct 2008 02:08:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roszenrami@...il.com
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, pekkas@...core.fi
Subject: Re: [PATCH 0/2] Multicast: add mc_count to in_device and to
 inet6_dev

From: "Rami Rosen" <roszenrami@...il.com>
Date: Wed, 1 Oct 2008 09:57:42 +0300

> Hi,
>     - This patch set adds mc_count to  struct in_device (IPv4) and to
> struct inet6_dev (IPv6) and updates increment/decrement/initialization
> of this field in IPv4 and in IPv6.
> 
> - Also printing the /proc entry (/proc/net/igmp) is adjusted to use
> the new mc_count.
> 
>  - Thanks to David Stevens for his feedback.

Why even add the mc_count to the ipv6 side if it isn't
even going to be used?  I see nothing actually reading
the ipv6 version of the value.

If you're going to do that eventually in some later
set of changes, add it then.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html