netdev - Re: [PATCH 0/2] Multicast: add mc_count to in_device and to inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b25312890810012224h68a2444dob746eaf0ce80b111@mail.gmail.com>
Date:	Thu, 2 Oct 2008 08:24:33 +0300
From:	"Rami Rosen" <roszenrami@...il.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, pekkas@...core.fi
Subject: Re: [PATCH 0/2] Multicast: add mc_count to in_device and to inet6_dev

Hi,
  - When sending the patch, I was aware that the mc_count is currently
not used (printed) in IPv6;
I added it for the sake of symmetry with IPv4 and for future use.
- Adding printing of mc_count in IPv6 is of course trivial; it was not
added not because of laziness;  I know less about IPv6 user space
tools (which read "/proc/net/igmp6") ; I was afraid that adding
printing of this mc_count field in IPv6 might break parsing of IPv6
user space tools (like netstat, etc).
So maybe this addition should be left for somebody who knows more
about IPv6 user space tools ?

Regards,
Rami Rosen


On Wed, Oct 1, 2008 at 12:08 PM, David Miller <davem@...emloft.net> wrote:
> From: "Rami Rosen" <roszenrami@...il.com>
> Date: Wed, 1 Oct 2008 09:57:42 +0300
>
>> Hi,
>>     - This patch set adds mc_count to  struct in_device (IPv4) and to
>> struct inet6_dev (IPv6) and updates increment/decrement/initialization
>> of this field in IPv4 and in IPv6.
>>
>> - Also printing the /proc entry (/proc/net/igmp) is adjusted to use
>> the new mc_count.
>>
>>  - Thanks to David Stevens for his feedback.
>
> Why even add the mc_count to the ipv6 side if it isn't
> even going to be used?  I see nothing actually reading
> the ipv6 version of the value.
>
> If you're going to do that eventually in some later
> set of changes, add it then.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html