netdev - Re: [PATCH 0/2] Multicast: add mc_count to in_device and to inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081007.153643.247018258.davem@davemloft.net>
Date:	Tue, 07 Oct 2008 15:36:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roszenrami@...il.com
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, pekkas@...core.fi
Subject: Re: [PATCH 0/2] Multicast: add mc_count to in_device and to
 inet6_dev

From: "Rami Rosen" <roszenrami@...il.com>
Date: Thu, 2 Oct 2008 08:24:33 +0300

>   - When sending the patch, I was aware that the mc_count is currently
> not used (printed) in IPv6;
> I added it for the sake of symmetry with IPv4 and for future use.

Unused struct members take up space in every instance of that
datastructure, so we don't add things like this until we have
real uses.

> - Adding printing of mc_count in IPv6 is of course trivial; it was not
> added not because of laziness;  I know less about IPv6 user space
> tools (which read "/proc/net/igmp6") ; I was afraid that adding
> printing of this mc_count field in IPv6 might break parsing of IPv6
> user space tools (like netstat, etc).
> So maybe this addition should be left for somebody who knows more
> about IPv6 user space tools ?

Of course modifying the output of this procfs file will break
things.  This is yet another reason to not add the ipv6 side
mc_count until we actually come up with a real use.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html