netdev - Re: [PATCH net-2.6 5/7] atm: [br2864] fix routed vcmux support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1222920551.23279.103.camel@sakura.staff.proxad.net>
Date:	Thu, 02 Oct 2008 06:09:11 +0200
From:	Maxime Bizon <mbizon@...ebox.fr>
To:	chas williams - CONTRACTOR <chas@....nrl.navy.mil>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-2.6 5/7] atm: [br2864] fix routed vcmux support


On Mon, 2008-06-16 at 13:27 -0400, chas williams - CONTRACTOR wrote:

Hello,

> commit 1390b21d5244dc3a8a929778ffd2fde05613c761
> Author: Eric Kinzie <ekinzie@....nrl.navy.mil>
> Date:   Sat Jun 14 17:33:35 2008 -0400
> 
>     atm: [br2864] fix routed vcmux support
>     
>     From: Eric Kinzie <ekinzie@....nrl.navy.mil>
>     Signed-off-by: Chas Williams <chas@....nrl.navy.mil>
> 
> diff --git a/net/atm/br2684.c b/net/atm/br2684.c
> index ac60350..05fafdc 100644
> --- a/net/atm/br2684.c
> +++ b/net/atm/br2684.c
> @@ -188,10 +188,13 @@ static int br2684_xmit_vcc(struct sk_buff *skb, struct br2684_dev *brdev,
>  				return 0;
>  			}
>  		}
> -	} else {
> -		skb_push(skb, 2);
> -		if (brdev->payload == p_bridged)
> +	} else { /* e_vc */
> +		if (brdev->payload == p_bridged) {
> +			skb_push(skb, 2);
>  			memset(skb->data, 0, 2);
> +		} else { /* p_routed */
> +			skb_pull(skb, ETH_HLEN);
> +		}
>  	}

Very old stuff sorry, but could you explain the skb_pull(skb, ETH_HLEN)
for e_vc/p_routed ?

netdevice is declared like this:

	netdev->hard_header_len = 0;
	netdev->type = ARPHRD_PPP;
	netdev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;

so there should be no ethernet header to remove.


Regards,

-- 
Maxime

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html