netdev - Re: cxgb3 - fix race in EEH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081008.155850.182279915.davem@davemloft.net>
Date:	Wed, 08 Oct 2008 15:58:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	divy@...lsio.com
CC:	akpm@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: cxgb3 - fix race in EEH

I've applied this patch to net-next-2.6, BUT...

You should show some signs of life and address the things
Andrew Morton asked you about when you posted this patch.

His questions and comments are included for your reference:

----------------------------------------
It's deeply weird that t3_reset_qset() does

	memset(&q->tx_reclaim_timer, 0, sizeof(q->tx_reclaim_timer));

There are lots of things in the timer_list which the driver has no
business modifying.  For example, this might break the metadata in
Thomas's debugobjects stuff, which attempts to catch things being done
in the wrong order (I don't think it will, but still...).

Rerunning init_timer() should repair the damage, but I suspect a simple

	q->tx_reclaim_timer.function = NULL;	/* explanation goes here */

would suffice here.

t3_sge_alloc_qset() could use the newer setup_timer().
----------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html