netdev - Re: cxgb3 - fix race in EEH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Oct 2008 16:10:53 -0700
From:	Divy Le Ray <divy@...lsio.com>
To:	David Miller <davem@...emloft.net>
CC:	akpm@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: cxgb3 - fix race in EEH

David Miller wrote:
> I've applied this patch to net-next-2.6, BUT...
>
> You should show some signs of life and address the things
> Andrew Morton asked you about when you posted this patch.
>
> His questions and comments are included for your reference:
>
> ----------------------------------------
> It's deeply weird that t3_reset_qset() does
>
> 	memset(&q->tx_reclaim_timer, 0, sizeof(q->tx_reclaim_timer));
>
> There are lots of things in the timer_list which the driver has no
> business modifying.  For example, this might break the metadata in
> Thomas's debugobjects stuff, which attempts to catch things being done
> in the wrong order (I don't think it will, but still...).
>
> Rerunning init_timer() should repair the damage, but I suspect a simple
>
> 	q->tx_reclaim_timer.function = NULL;	/* explanation goes here */
>
> would suffice here.
>
>
> t3_sge_alloc_qset() could use the newer setup_timer().
> ----------------------------------------
>   

Hi Dave,

I've got a series of patches almost ready to go against net-next-2.6 - 
hopefully within the next hour, and it includes a fix for this.
I was hoping to push the patches earlier this week, thus replying to 
Andrew's concerns. It's obviously taking longer than expected to get 
these patches out. I should have answered Andrew nonetheless.
The patch series will integrate Andrew'suggestions.

Cheers,
Divy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html