netdev - Re: [PATCH] sky2: Fix recent WOL regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200810092301.36633.rjw@sisk.pl>
Date:	Thu, 9 Oct 2008 23:01:35 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, jeff@...zik.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	tino.keitel@....de, netdev@...r.kernel.org,
	jbarnes@...tuousgeek.org
Subject: Re: [PATCH] sky2: Fix recent WOL regression

On Thursday, 9 of October 2008, David Miller wrote:
> From: "Rafael J. Wysocki" <rjw@...k.pl>
> Date: Thu, 9 Oct 2008 00:55:55 +0200
> 
> > On Friday, 3 of October 2008, Stephen Hemminger wrote:
> > > On Thu, 2 Oct 2008 23:39:33 +0200
> > > "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> > > 
> > > > From: Rafael J. Wysocki <rjw@...k.pl>
> > > > 
> > > > sky2: Fix recent WOL regression
> > > > 
> > > > Since dev->power.should_wakeup bit is used by the PCI core to
> > > > decide whether the device should wake up the system from sleep
> > > > states, set/unset this bit whenever WOL is enabled/disabled using
> > > > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > > > machine).
> > > > 
> > > > Remove an open-coded reference to the standard PCI PM registers that
> > > > is not used any more.
> > > > 
> > > > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> > > > Reported-by: Tino Keitel <tino.keitel@....de>
> > > > ---
> > > 
> > > Acked-by: Stephen Hemminger <shemminger@...tta.com>
> > > 
> > > Thanks for fixing this.
> > 
> > Can you please include this patch into your next push for Jeff?
> > 
> > It seems to have been overlooked.
> 
> I missed this ACK but I did add the patch to my tree as you
> can see from another email of mine.

I saw it, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html