netdev - Re: [PATCH net-next 4/6] bnx2: Eliminate TSO header modifications.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1223585799.23468.4.camel@HP1>
Date:	Thu, 09 Oct 2008 13:56:39 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 4/6] bnx2: Eliminate TSO header
 modifications.

On Thu, 2008-10-09 at 12:25 -0700, David Miller wrote:
> From: "Michael Chan" <mchan@...adcom.com>
> Date: Thu,  9 Oct 2008 10:16:06 -0700
> 
> > This is now possible with updated firmware.
> >
> > Signed-off-by: Michael Chan <mchan@...adcom.com>
> 
> Nice, applied.
> 
> Quick question, in the intermediate step where we have the
> new firmware (patch #3) but not this change applied (patch
> #4) does TSO still work properly?

It will still work.  The firmware will overwrite the header fields
modified (unnecessarily) by the driver.

> 
> If TSO is bolixed after patch #3 but before patch #4 please
> don't create those kinds of non-bisectable situations in
> the future.  I'd rather you do the firmware update and the
> TSO logic changes all in one go to keep it all working.
> 
> Thanks!
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html