netdev - Re: [PATCH 1/4] tcpv[46]: fix md5 pseudoheader address field ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081009.143755.201233180.davem@davemloft.net>
Date:	Thu, 09 Oct 2008 14:37:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/4] tcpv[46]: fix md5 pseudoheader address field
 ordering

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Thu,  9 Oct 2008 12:35:34 +0300

> Maybe it's just me but I guess those md5 people made a mess
> out of it by having *_md5_hash_* to use daddr, saddr order
> instead of the one that is natural (and equal to what csum
> functions use). For the segment were sending, the original
> addresses are reversed so buff's saddr == skb's daddr and
> vice-versa.
> 
> Maybe I can finally proceed with unification of some code
> after fixing it first... :-)
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html