netdev - Re: [PATCH 2/4] tcpv6: trivial formatting changes to send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081009.143859.113768989.davem@davemloft.net>
Date:	Thu, 09 Oct 2008 14:38:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	acme@...hat.com
Cc:	ilpo.jarvinen@...sinki.fi, yoshfuji@...ux-ipv6.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/4] tcpv6: trivial formatting changes to
 send_(ack|reset)

From: Arnaldo Carvalho de Melo <acme@...hat.com>
Date: Thu, 9 Oct 2008 11:16:58 -0300

> Em Thu, Oct 09, 2008 at 12:58:07PM +0300, Ilpo Järvinen escreveu:
> > On Thu, 9 Oct 2008, YOSHIFUJI Hideaki / ???? wrote:
> > > I usually prefer sizeof(var) (or sizeof(*ptr)) over sizeof(type).
> > > Could you justify this change?
> > 
> > My point was to make those two functions as equal as possible before merge 
> > so that it's more easier to track what happens at the merge, both 
> > versions pre-existed anyway. Sure I don't have much opinion either way.
> 
> I agree with Yoshifuji, albeit it is unlikely that the type of that
> variable will change 8)

I agree as well and therefore left out the first hunk of this
patch when adding it to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html