lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Oct 2008 13:37:14 -0700 From: Alexander Duyck <alexander.h.duyck@...el.com> To: Jarek Poplawski <jarkao2@...il.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH 00/14]: Killing qdisc->ops->requeue(). Jarek Poplawski wrote: > On Tue, Oct 14, 2008 at 09:41:30AM -0700, Alexander Duyck wrote: > ... >> I think if anything it seems like you guys actually found the cpu >> performance issue a while back in the fact that the dev_requeue_skb was >> calling __netif_schedule when requeuing on a stopped queue. That is the >> one piece I would say needs to be changed so that you only call >> __netif_schedule if the skb is not going to a stopped queue. > > BTW, since one of the other "dreams" of killing requeuing failed, I > think this proposal is worth checking, but David was concerned about > some issues with buggy drivers after __netif_schedule() removing. > > Jarek P. I would say not to remove it. Just add a check to verify that the queue the packet is bound for is not stopped prior to calling it. If the queue is stopped it should be rescheduled by the wake_queue call when the device has cleared the queue. Unfortunately I am currently working on other projects so I don't really have the time to create and test a patch for this. Hopefully my input has proven useful. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists