netdev - Re: [PATCH 1/6] [NET-NEXT]qlge: Clean up and fix MSI and legacy irq handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081014204025.GB9617@electric-eye.fr.zoreil.com>
Date:	Tue, 14 Oct 2008 22:40:25 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ron Mercer <ron.mercer@...gic.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org, linux-driver@...gic.com
Subject: Re: [PATCH 1/6] [NET-NEXT]qlge: Clean up and fix MSI and legacy
	irq handling.

Ron Mercer <ron.mercer@...gic.com> :
[...]
> Your example looks much better than what I had, but it reverses the
> logic and won't work.  What I'm trying to do is skip the operation if
> we're running with MSIX-multiple interrupts AND it's not context zero.

Ok, ok.

> For all other cases we do the operation.  So fixing your suggestion it would
> be:
[snip]
> This is more compact, it's still optimized, but I think it becomes a
> little hard to read.

Remove 'unlikely' ?

> I'll gladly try it and make the change if you

Your choice. I'm fine with Roland's code as well.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html