lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1224023293-8592-1-git-send-email-afleming@freescale.com>
Date:	Tue, 14 Oct 2008 17:28:13 -0500
From:	Andy Fleming <afleming@...escale.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, Andy Fleming <afleming@...escale.com>
Subject: [PATCH] Change S390 anti-dependency to CONFIG_GENERIC_HARDIRQS dependency

PHY Lib and DSA expect request_irq and other such functions to exist.
S390 doesn't support those functions, however we should mark the actual
dependency, which is generic hardirq support, rather than explicitly
depend on !S390.

Signed-off-by: Andy Fleming <afleming@...escale.com>
---
This makes more sense to me, but I could be missing something?

 drivers/net/phy/Kconfig |    2 +-
 net/dsa/Kconfig         |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index d55932a..73027a0 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -4,7 +4,7 @@
 
 menuconfig PHYLIB
 	tristate "PHY Device support and infrastructure"
-	depends on !S390
+	depends on GENERIC_HARDIRQS
 	depends on NET_ETHERNET
 	help
 	  Ethernet controllers are usually attached to PHY
diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
index 49211b3..ea9c5aa 100644
--- a/net/dsa/Kconfig
+++ b/net/dsa/Kconfig
@@ -1,7 +1,7 @@
 menuconfig NET_DSA
 	bool "Distributed Switch Architecture support"
 	default n
-	depends on EXPERIMENTAL && !S390
+	depends on EXPERIMENTAL && GENERIC_HARDIRQS
 	select PHYLIB
 	---help---
 	  This allows you to use hardware switch chips that use
-- 
1.5.4.GIT

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ