netdev - [PATCH for 2.6.27] Structure icmp6hdr (IPv6/ICMPv6) with bug in the bitfields!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1338007712.20081014233811@net.ipl.pt>
Date:	Tue, 14 Oct 2008 23:38:11 +0100
From:	Pedro Ribeiro <pribeiro-bulk@....ipl.pt>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: [PATCH for 2.6.27] Structure icmp6hdr (IPv6/ICMPv6) with bug in the bitfields!

Hello David,

Thanks for your time on this, follows a new patch made against 2.6.27,
this time I minimized the cut&paste to avoid corrupting the patch.

diff -wurNbB linux-2.6.27/include/linux/icmpv6.h linux-2.6.27fix/include/linux/icmpv6.h
--- linux-2.6.27/include/linux/icmpv6.h 2008-10-09 23:13:53.000000000 +0100
+++ linux-2.6.27fix/include/linux/icmpv6.h      2008-10-14 23:24:31.000000000 +0100
@@ -40,16 +40,18 @@
                 struct icmpv6_nd_ra {
                        __u8            hop_limit;
 #if defined(__LITTLE_ENDIAN_BITFIELD)
-                       __u8            reserved:4,
+                       __u8            reserved:3,
                                        router_pref:2,
+                                       home_agent:1,
                                        other:1,
                                        managed:1;
 
 #elif defined(__BIG_ENDIAN_BITFIELD)
                        __u8            managed:1,
                                        other:1,
+                                       home_agent:1,
                                        router_pref:2,
-                                       reserved:4;
+                                       reserved:3;
 #else
 #error "Please fix <asm/byteorder.h>"
 #endif
diff -wurNbB linux-2.6.27/net/ipv6/ndisc.c linux-2.6.27fix/net/ipv6/ndisc.c
--- linux-2.6.27/net/ipv6/ndisc.c       2008-10-09 23:13:53.000000000 +0100
+++ linux-2.6.27fix/net/ipv6/ndisc.c    2008-10-14 23:24:31.000000000 +0100
@@ -1199,7 +1199,7 @@
                }
                neigh->flags |= NTF_ROUTER;
        } else if (rt) {
-               rt->rt6i_flags |= (rt->rt6i_flags & ~RTF_PREF_MASK) | RTF_PREF(pref);
+               rt->rt6i_flags = (rt->rt6i_flags & ~RTF_PREF_MASK) | RTF_PREF(pref);
        }
 
        if (rt)



Best regards.

Tuesday, October 14, 2008, 9:54:23 PM, you wrote:

> From: Pedro Ribeiro <pribeiro-bulk@....ipl.pt>
> Date: Tue, 14 Oct 2008 12:06:20 +0100

>> Follows a “diff” with the changes I’ve made to correct this problem
>> (I’ve made it against kernel 2.6.23, but I’ve confirmed that the
>> problem still exists in 2.6.25)

> Please make your patch against current sources, it does not apply
> to the current tree.
> ..?.?칻.?&?.???.a??e??A.ǧt.a|.b??A?{.n?+?????]z?A?{a|.?w0h|.???,j.???fj:+v??.?.?..?w?.??2??.f???h??b??Aj?A??i.????????zPh?.?j:+v??.)ߤ.m?



-- 
Best regards,

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Pedro Ribeiro
IPLNet - Rede de dados e comunicações
Instituto Politécnico de Lisboa (IPL)
Mail: mailto:pribeiro-bulk@....ipl.pt
VoIP: sip:pribeiro@....ipl.pt
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html