netdev - Re: Error: an inet prefix is expected rather than "0/0".

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081014121855.2f931be0@extreme>
Date:	Tue, 14 Oct 2008 12:18:55 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Krzysztof Oledzki <ole@....pl>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>, netdev@...r.kernel.org
Subject: Re: Error: an inet prefix is expected rather than "0/0".

On Tue, 14 Oct 2008 21:15:18 +0200 (CEST)
Krzysztof Oledzki <ole@....pl> wrote:

> 
> 
> On Tue, 14 Oct 2008, Stephen Hemminger wrote:
> 
> > On Tue, 14 Oct 2008 22:01:27 +0800
> > Herbert Xu <herbert@...dor.apana.org.au> wrote:
> >
> >> Krzysztof Oledzki <ole@....pl> wrote:
> >>>
> >>> http://git.kernel.org/?p=linux/kernel/git/shemminger/iproute2.git;a=commitdiff_plain;h=2ca4abdcb823e708b88156f947fa5b493055618a
> >>>
> >>> ;)
> >>
> >> Hmm, this breaks several scripts of mine that use 10/8.  Couldn't
> >> we just fall back to the old loop when inet_aton fails?
> >>
> >> Thanks,
> >
> >
> > There is no easy solution, I'll will have to go back rewrite this
> > code, and will document the result. I expect the result will displease
> > someone, but given the original code that is just going to happen.
> >
> > Busted cases:
> >                           correct           incorrect
> > Original code: 127.2   =>  127.0.0.2         127.2.0.0
> > inet_pton:     10.0    =>  10.0.0.0          fails invalid
> > inet_aton:     10      =>  10.0.0.0          0.0.0.10
> >
> > The problem was Alexey (or Jamal) invented their own abbreviation format
> > and did not follow unix standard conventions.
> 
> It seems that the original code followed the unix standard:
> 
> # telnet 127.2
> Trying 127.0.0.2...
> telnet: connect to address 127.0.0.2: Connection refused

The incorrect column lists the actual result for each of the routines.
Original code converted 127.2 to 127.2.0.0
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html