netdev - Re: [patch] rtl8102e: commit 7bf6bf480 zeroized MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Oct 2008 00:50:23 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	c4p7n@...itanio.org
Cc:	Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org,
	kernel@...r.kernel.org
Subject: Re: [patch] rtl8102e: commit 7bf6bf480 zeroized MAC address

c4p7n@...itanio.org <c4p7n@...itanio.org> :
> May be we are reading just by luck zeros and not a random perfectly
> sane address.

I would use the attached patches. The former one is mostly Ivan's one
with some rework of the debug messages. The later checks the eeprom
for its signature.

With these patches the driver notices that it can not get an address
for my 8168b but it works ok with my 8169 after both an hot and a
cold boot. Interestingly enough, the VPD is not enabled on the 8169
during the first boot.

Ivan, can you test them (and fix them afterwards :o) ) ?

-- 
Ueimor

View attachment "a" of type "text/plain" (1346 bytes)

View attachment "b" of type "text/plain" (2057 bytes)