netdev - Re: [stable] [PATCH] [stable 2.6.27.y] don't take the mdio_lock in atl1e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081015224736.GB22897@kroah.com>
Date:	Wed, 15 Oct 2008 15:47:36 -0700
From:	Greg KH <greg@...ah.com>
To:	David Miller <davem@...emloft.net>
Cc:	jacliburn@...lsouth.net, jcliburn@...il.com, nm127@...email.hu,
	netdev@...r.kernel.org, jie.yang@...eros.com, jgarzik@...hat.com,
	willy@...ux.intel.com, akpm@...ux-foundation.org,
	csnook@...hat.com, stable@...nel.org
Subject: Re: [stable] [PATCH] [stable 2.6.27.y] don't take the mdio_lock in
	atl1e_probe

On Wed, Oct 15, 2008 at 03:41:45PM -0700, David Miller wrote:
> From: Greg KH <greg@...ah.com>
> Date: Wed, 15 Oct 2008 15:15:37 -0700
> 
> > On Sat, Oct 11, 2008 at 11:08:16AM -0700, David Miller wrote:
> > > From: Jay Cliburn <jacliburn@...lsouth.net>
> > > Date: Sat, 11 Oct 2008 10:05:01 -0500
> > > 
> > > > From: Matthew Wilcox <matthew@....cx>
> > > > 
> > > > Upstream commit: f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd
> > > > 
> > > > This fixes bug 11736.
> > > > 
> > > > http://marc.info/?l=linux-netdev&m=122367387219316&w=2
> > > > 
> > > > Lockdep warns about the mdio_lock taken with interrupts enabled then
> > > > later taken from interrupt context.  Initially, I considered changing
> > > > these to spin_lock_irq/spin_unlock_irq, but then I looked at
> > > > atl1e_phy_init() and saw that it calls msleep().  Sleeping while
> > > > holding a spinlock is not allowed either.
> > > > 
> > > > In the probe path, we haven't registered the interrupt handler, so
> > > > it can't poke at this card yet.  It's before we call register_netdev(),
> > > > so I don't think any other threads can reach this card either.  If I'm
> > > > right, we don't need a spinlock at all.
> > > > 
> > > > Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
> > > > Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
> > > 
> > > Signed-off-by: David S. Miller <davem@...emloft.net>
> > 
> > Does this mean you will forward this to -stable in a bunch of network
> > patches?  Or should I take it now?
> 
> Please take this one now, t hanks.

Will do, thanks for the quick response.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html