netdev - Re: [PATCH] AX88796: ax_probe() fix irq assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2008 01:15:16 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	roel kluin <roel.kluin@...il.com>
CC:	ben-linux@...ff.org, netdev@...r.kernel.org
Subject: Re: [PATCH] AX88796: ax_probe() fix irq assignment

roel kluin wrote:
> dev->irq is unsigned
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 4207d6e..9a314d8 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
>  
>  	/* find the platform resources */
>  
> -	dev->irq  = platform_get_irq(pdev, 0);
> -	if (dev->irq < 0) {
> +	ret  = platform_get_irq(pdev, 0);
> +	if (ret < 0) {
>  		dev_err(&pdev->dev, "no IRQ specified\n");
> -		ret = -ENXIO;
>  		goto exit_mem;
>  	}
> +	dev->irq = ret;

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html