netdev - Re: [PATCH] myri10ge: disable NAPI on failure to setup the interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48FD6573.1080400@garzik.org>
Date:	Tue, 21 Oct 2008 01:15:31 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Brice Goglin <brice@...i.com>
CC:	Jeff Garzik <jgarzik@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] myri10ge: disable NAPI on failure to setup the interface

Brice Goglin wrote:
> Disable NAPI if a failure occurs when setting up the interface. Leaving
> it enabled could cause a BUG the next time an ifconfig up is issued.
> 
> Signed-off-by: Brice Goglin <brice@...i.com>
> 
> --- linux-2.6/drivers/net/myri10ge/myri10ge.c	2008-10-20 08:36:48.000000000 +0200
> +++ linux-tmp/drivers/net/myri10ge/myri10ge.c	2008-10-20 13:47:21.000000000 +0200
> @@ -75,7 +75,7 @@
>  #include "myri10ge_mcp.h"
>  #include "myri10ge_mcp_gen_header.h"
>  
> -#define MYRI10GE_VERSION_STR "1.4.3-1.369"
> +#define MYRI10GE_VERSION_STR "1.4.3-1.371"
>  
>  MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
>  MODULE_AUTHOR("Maintainer: help@...i.com");
> @@ -2497,6 +2497,10 @@ static int myri10ge_open(struct net_devi
>  	return 0;
>  
>  abort_with_rings:
> +	while (slice) {
> +		slice--;
> +		napi_disable(&mgp->ss[slice].napi);
> +	}

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html