netdev - Re: Possible bug in bonding driver (with VLAN in ALB mode)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1830.1224612755@death.nxdomain.ibm.com>
Date:	Tue, 21 Oct 2008 11:12:35 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Sven Anders <anders@...uras.de>
cc:	netdev@...r.kernel.org
Subject: Re: Possible bug in bonding driver (with VLAN in ALB mode)

Sven Anders <anders@...uras.de> wrote:
[...]
>After an ARP request was sent (by the router) in the "rlb_arp_xmit()",
>the "rlb_choose_channel()" function is called and reserves a
>(placeholder) entry in the hash table. According to the comment this
>entry will be updated later by the corresponding ARP reply.
>Shortly afterwards we see an ARP reply package on the VLAN interface.
>But it is never processed by "rlb_arp_recv()", because this function
>only receives arp packages from bond0 and so the entry is never
>updated.

	Can you try this patch and tell me if it fixes the problem?

diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index ade5f3f..500a207 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -815,7 +815,7 @@ static int rlb_initialize(struct bonding *bond)
 
 	/*initialize packet type*/
 	pk_type->type = __constant_htons(ETH_P_ARP);
-	pk_type->dev = bond->dev;
+	pk_type->dev = NULL;
 	pk_type->func = rlb_arp_recv;
 
 	/* register to receive ARPs */


	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html