netdev - Re: [PATCH] Implement polling for 5200FEC to make netconsole work.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa686aa40810211657q33575bcfj7c5fe4a4cb4dab27@mail.gmail.com>
Date:	Tue, 21 Oct 2008 17:57:03 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Jon Smirl" <jonsmirl@...il.com>
Cc:	linuxppc-dev@...abs.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Implement polling for 5200FEC to make netconsole work.

On Tue, Oct 21, 2008 at 5:41 PM, Jon Smirl <jonsmirl@...il.com> wrote:
> Is anyone going to pick this up?

I'm looking at it, but I'm not picking it up for .28.  It's
non-trivial enough that I would have needed to have it before the
merge window opened to get it into .28.

g.

>
> On Sat, Oct 18, 2008 at 5:40 PM, Jon Smirl <jonsmirl@...il.com> wrote:
>> Implement polling for 5200FEC to make netconsole work. Tested on Phytec pcm030 and Efika.
>>
>> Signed-off-by: Jon Smirl <jonsmirl@...il.com>
>> ---
>>  drivers/net/fec_mpc52xx.c |   18 ++++++++++++++++++
>>  1 files changed, 18 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
>> index 4e4f683..aec3b97 100644
>> --- a/drivers/net/fec_mpc52xx.c
>> +++ b/drivers/net/fec_mpc52xx.c
>> @@ -401,6 +401,21 @@ static int mpc52xx_fec_hard_start_xmit(struct sk_buff *skb, struct net_device *d
>>        return 0;
>>  }
>>
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void mpc52xx_fec_poll_controller(struct net_device *dev)
>> +{
>> +       struct mpc52xx_fec_priv *priv = netdev_priv(dev);
>> +
>> +       disable_irq(priv->t_irq);
>> +       mpc52xx_fec_tx_interrupt(priv->t_irq, dev);
>> +       enable_irq(priv->t_irq);
>> +       disable_irq(priv->r_irq);
>> +       mpc52xx_fec_rx_interrupt(priv->r_irq, dev);
>> +       enable_irq(priv->r_irq);
>> +}
>> +#endif
>> +
>> +
>>  /* This handles BestComm transmit task interrupts
>>  */
>>  static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
>> @@ -926,6 +941,9 @@ mpc52xx_fec_probe(struct of_device *op, const struct of_device_id *match)
>>        ndev->tx_timeout        = mpc52xx_fec_tx_timeout;
>>        ndev->watchdog_timeo    = FEC_WATCHDOG_TIMEOUT;
>>        ndev->base_addr         = mem.start;
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +       ndev->poll_controller = mpc52xx_fec_poll_controller;
>> +#endif
>>
>>        priv->t_irq = priv->r_irq = ndev->irq = NO_IRQ; /* IRQ are free for now */
>>
>>
>>
>
>
>
> --
> Jon Smirl
> jonsmirl@...il.com
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html