[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <EA929A9653AAE14F841771FB1DE5A1365F49CD6EE4@rrsmsx501.amr.corp.intel.com>
Date: Wed, 22 Oct 2008 12:01:16 -0600
From: "Williams, Mitch A" <mitch.a.williams@...el.com>
To: Jeff Garzik <jeff@...zik.org>,
Stephen Hemminger <shemminger@...tta.com>
CC: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"e1000-devel@...ts.sourceforge.net"
<e1000-devel@...ts.sourceforge.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] e1000e: get rid of wasted space
Jeff Garzik wrote:
>
>Stephen Hemminger wrote:
>> The name in the ring is only used once during setup so it shouldn't
>> be in the data structure.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
[snip]
>
>ACK
>
>for what it's worth... I am following DaveM's lead, and waiting until
>net-next opens to start taking patches for 2.6.29. He wants
>us to focus
>on bug fixing for now.
>
>So, please resend once the merge window opens... thanks.
>
NAK. Seriously. Don't resend this. NAK.
That string DOES get used later, like when you cat /proc/interrupts.
So you can't allocate it on the stack. It's got to be persistent,
just like we have it. Heck, look at the declaration for
request_irq(). The devname param is declared as const char *.
So NAK. Same for igb and ixgbe. Don't do this.
-Mitch
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists