netdev - Re: [PATCH] e1000e: get rid of wasted space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2008 11:07:07 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>
Cc:	Jeff Garzik <jeff@...zik.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] e1000e: get rid of wasted space

On Wed, 22 Oct 2008 12:01:16 -0600
"Williams, Mitch A" <mitch.a.williams@...el.com> wrote:

> Jeff Garzik wrote:
> 
> >
> >Stephen Hemminger wrote:
> >> The name in the ring is only used once during setup so it shouldn't
> >> be in the data structure.
> >>
> >> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> [snip]
> >
> >ACK
> >
> >for what it's worth...  I am following DaveM's lead, and waiting until
> >net-next opens to start taking patches for 2.6.29.  He wants
> >us to focus
> >on bug fixing for now.
> >
> >So, please resend once the merge window opens... thanks.
> >
> 
> NAK.  Seriously. Don't resend this.  NAK.
> 
> That string DOES get used later, like when you cat /proc/interrupts.
> So you can't allocate it on the stack.  It's got to be persistent,
> just like we have it.  Heck, look at the declaration for
> request_irq().  The devname param is declared as const char *.
> 
> So NAK.  Same for igb and ixgbe.  Don't do this.
> 
> -Mitch

The comments were right, this needs to stay, although it might be better
to use a bigger field to allow full width of IFNAME+5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html