netdev - Re: suspicious logic in tcp_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Oct 2008 23:11:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	agl@...erialviolet.org, netdev@...r.kernel.org
Subject: Re: suspicious logic in tcp_make_synack()

From: Florian Westphal <fw@...len.de>
Date: Sun, 26 Oct 2008 18:41:47 +0100

> syncookies: fix inclusion of tcp options in syn-ack
> 
> David Miller noticed that commit
> 33ad798c924b4a1afad3593f2796d465040aadd5 '(tcp: options clean up')
> did not move the req->cookie_ts check.
> This essentially disabled commit 4dfc2817025965a2fc78a18c50f540736a6b5c24
> '[Syncookies]: Add support for TCP options via timestamps.'.
> 
> This restores the original logic.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks a lot Florian.

I can't count on my two hands how many bugs were caused by that one
single commit :-(
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html