netdev - Re: suspicious logic in tcp_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Oct 2008 08:51:19 -0700
From:	"Adam Langley" <agl@...erialviolet.org>
To:	"David Miller" <davem@...emloft.net>
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: suspicious logic in tcp_make_synack()

On Sun, Oct 26, 2008 at 11:11 PM, David Miller <davem@...emloft.net> wrote:
> I can't count on my two hands how many bugs were caused by that one
> single commit :-(

I should have made more of an effort to keep up with netdev during the
.27 release, rather than just the rc's, so I fear that I didn't see
all the bugs. I'll go though the archives today.

Although that commit was born of an attempt to save some people from
some of the pitfalls of modifying the previous code it clearly wasn't
something that I should have attempted. The cost of newbies touching
code in that area is too great both in tickling bugs in other systems
(with option ordering) and in stupid omissions like this. It's
probably been too long to revert it wholesale now, so I can only
attempt to be more parsimonious in the future and hope that that's the
last of the pain. If nothing else, suspicion of that commit has
probably been raised to such a level that competent folks have checked
it all over now.

AGL

-- 
Adam Langley agl@...erialviolet.org http://www.imperialviolet.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html