netdev - Re: suspicious logic in tcp_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 27 Oct 2008 11:30:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	agl@...erialviolet.org
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: suspicious logic in tcp_make_synack()

From: "Adam Langley" <agl@...erialviolet.org>
Date: Mon, 27 Oct 2008 08:51:19 -0700

> Although that commit was born of an attempt to save some people from
> some of the pitfalls of modifying the previous code it clearly wasn't
> something that I should have attempted. The cost of newbies touching
> code in that area is too great both in tickling bugs in other systems
> (with option ordering) and in stupid omissions like this.

Adam, as I said, you and I share this burdon :-)  I should have
reviewed your changes more thoroughly, and for this change that is
true no matter who actually wrote it.

> If nothing else, suspicion of that commit has probably been raised
> to such a level that competent folks have checked it all over now.

Yes, I think we've fixed up all the issues by now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html