netdev - Re: [PATCH 00/09]IPtablestng/Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081028000044.GA16721@ioremap.net>
Date:	Tue, 28 Oct 2008 03:00:44 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	hamid jafarian <hamid.jafarian@...il.com>
Cc:	Netfilter-devel <netfilter-devel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Patrick McHardy <kaber@...sh.net>,
	Jan Engelhardt <jengelh@...ozas.de>,
	David Miller <davem@...emloft.net>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Harald Welte <laforge@...monks.org>,
	Eric Leblond <eric@....fr>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	Amin Azez <azez@...mechanic.net>
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables

Hi.

On Mon, Oct 27, 2008 at 07:58:33AM +0330, hamid jafarian (hamid.jafarian@...il.com) wrote:
> New Framework for IPtables

Frankly saying your codying style is way out of expected range of
allowed glitches, so it is quite hard to review the whole thing. Please
update it to at least remotely match existing code. Also I noticed you
do not use list iteration functions sometimes and replaces them with
direct access to next/prev pointers, which is not a good idea.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html