netdev - Re: [PATCH 00/09]IPtablestng/Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081027.170211.119803913.davem@davemloft.net>
Date:	Mon, 27 Oct 2008 17:02:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zbr@...emap.net
Cc:	hamid.jafarian@...il.com, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org, pablo@...filter.org, kaber@...sh.net,
	jengelh@...ozas.de, rusty@...tcorp.com.au, laforge@...monks.org,
	eric@....fr, kadlec@...ckhole.kfki.hu, azez@...mechanic.net
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables

From: Evgeniy Polyakov <zbr@...emap.net>
Date: Tue, 28 Oct 2008 03:00:44 +0300

> On Mon, Oct 27, 2008 at 07:58:33AM +0330, hamid jafarian (hamid.jafarian@...il.com) wrote:
> > New Framework for IPtables
> 
> Frankly saying your codying style is way out of expected range of
> allowed glitches, so it is quite hard to review the whole thing. Please
> update it to at least remotely match existing code. Also I noticed you
> do not use list iteration functions sometimes and replaces them with
> direct access to next/prev pointers, which is not a good idea.

And also please remove me from the CC: list as I have zero interest
in these patches.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html