netdev - Re: [PATCH 00/09]IPtablestng/Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <464293e60810280302j26112754o72c1cf3ebd6a0b1f@mail.gmail.com>
Date:	Tue, 28 Oct 2008 13:32:06 +0330
From:	"hamid jafarian" <hamid.jafarian@...il.com>
To:	"Evgeniy Polyakov" <zbr@...emap.net>
Cc:	Netfilter-devel <netfilter-devel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>,
	"Pablo Neira Ayuso" <pablo@...filter.org>,
	"Patrick McHardy" <kaber@...sh.net>,
	"Jan Engelhardt" <jengelh@...ozas.de>,
	"Rusty Russell" <rusty@...tcorp.com.au>,
	"Harald Welte" <laforge@...monks.org>,
	"Eric Leblond" <eric@....fr>,
	"Jozsef Kadlecsik" <kadlec@...ckhole.kfki.hu>,
	"Amin Azez" <azez@...mechanic.net>
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables

hi, &  special thanks

On Tue, Oct 28, 2008 at 3:30 AM, Evgeniy Polyakov <zbr@...emap.net> wrote:
> Frankly saying your codying style is way out of expected range of
> allowed glitches, so it is quite hard to review the whole thing. Please
> update it to at least remotely match existing code.

excuse for this loosely patches...
please more explain...
do you mean my patches are too long? or ambiguous?
i 've tried to code base on "Documentation/CodingStyle".. and patch
base on "how to participate in the kernel community" documents.

the core of this framework is located at pkt_tables.c&.h (#2&#3 of
kernel patches).
iptables.c&.h are completely changed. also at the user space libiptc.c
is rewritten from scratch thus their patches are really ambiguous to
be understood..what is the best way to send this patches?
what this phrase mean: "' remotely match existing code ""?

>Also I noticed you
> do not use list iteration functions sometimes and replaces them with
> direct access to next/prev pointers, which is not a good idea.
ok, i 've used this style to free list elements.
if you mean "don't use direct access to prev/next", i 'll review my
code and will try to use list iteration function on every place that
is possible or at list use list functions and list element of
structures instead of direct access to "next/prev"..

-- 
Hamid Jafarian (hm.t)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html