netdev - Re: [PATCH 00/09]IPtablestng/Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Oct 2008 13:43:46 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	hamid jafarian <hamid.jafarian@...il.com>
Cc:	Netfilter-devel <netfilter-devel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Patrick McHardy <kaber@...sh.net>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Harald Welte <laforge@...monks.org>,
	Eric Leblond <eric@....fr>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	Amin Azez <azez@...mechanic.net>
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables

Hi.

On Tue, Oct 28, 2008 at 01:32:06PM +0330, hamid jafarian (hamid.jafarian@...il.com) wrote:
> excuse for this loosely patches...
> please more explain...
> do you mean my patches are too long? or ambiguous?
> i 've tried to code base on "Documentation/CodingStyle".. and patch
> base on "how to participate in the kernel community" documents.
> 
> the core of this framework is located at pkt_tables.c&.h (#2&#3 of
> kernel patches).
> iptables.c&.h are completely changed. also at the user space libiptc.c
> is rewritten from scratch thus their patches are really ambiguous to
> be understood..what is the best way to send this patches?
> what this phrase mean: "' remotely match existing code ""?

I mean just coding style: spaces, braces, parentheses, function names
like __something_small_AND_CAPITAL. checkpatch.pl may help, although imo
it should not be followed strickly. It will much simpler to review changes.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html